On 23 November 2011 21:53, Max Filippov <jcmvb...@gmail.com> wrote: > --*dir) option pattern precede --{en,dis}able-usb-redir) patterns in the > option analysis switch, making the latter options have no effect. > > Signed-off-by: Max Filippov <jcmvb...@gmail.com>
I just said this in the other thread, but to repeat it in the right place: I think we should expand out the case statement to explicitly list the --thingydir options it is supposed to be matching, and drop the wildcard: as this bug demonstrates it's rather easy to accidentally shoot yourself in the foot with it. In fact, what cases is this supposed to be matching? All the documented --thingydir options are handled explicitly earlier in the case statement. Paolo, you added this case in commit 6bde81cb0, but the commit message doesn't give any rationale; what's it for? -- PMM