On 3/7/22 22:43, Mark Cave-Ayland wrote:
+ qdev_realize(DEVICE(cpu), NULL, &error_fatal); + object_unref(CPU(cpu));I believe this can be replaced with qdev_realize_and_unref()?
Oh, nice. I copied this from hw/arm/virt, which has code between these two points.
+ if (nms->vic) { + DeviceState *dev = qdev_new("nios2-vic");And with a separate header for nios2_vic.h you can include that and use TYPE_NIOS2_VIC here instead of hard-coding the type name.
Ok. r~