On 11/24/2011 03:31 PM, Benoît Canet wrote: > These patches convert some files to memory API > > I am wondering if the bonito ones are corrects as > sysbus_mmio_map() use internally get_system_memory().
>From a "will it work" perspective, I think it's correct since it system_memory is supposed to be equivalent to cpu_register_physical_memory(). >From an "is this the right thing", well, we'll need to hack up sysbus not to call get_system_memory() itself, but that's an unrelated problem. > v2: > remove unneeded casts in mcf_uart > remove unneeded #include in lm32_uart and lm32_sys > > v3: > use valid.accept in lm32_sys > > v4: > bonito: use the pci_host sysbus pointer > bonito: use pci_host->conf_mem and pci_host->data_mem > Looks good to me. I'll apply next week to allow people to review. -- error compiling committee.c: too many arguments to function
