Re: [PATCH v2 9/9] dump: Consolidate elf note function

[Richard Henderson]

On 3/10/22 03:08, Janosch Frank wrote:

+static void write_elf_notes(DumpState *s, Error **errp)
+{
+    ERRP_GUARD();
+
+    if (dump_is_64bit(s)) {
+        write_elf64_notes(fd_write_vmcore, s, errp);
+    } else {
+        write_elf32_notes(fd_write_vmcore, s, errp);
+    }
+    if (*errp) {
+        return;
+    }
+}

Are you anticipating adding more code to this function?
Otherwise the early return, and the guard are useless.


r~