Hi On Wed, Mar 16, 2022 at 5:00 PM Markus Armbruster <[email protected]> wrote: > > Marc-André Lureau <[email protected]> writes: > > > Hi > > > > On Wed, Mar 16, 2022 at 4:33 PM Markus Armbruster <[email protected]> wrote: > >> > >> [email protected] writes: > >> > >> > From: Marc-André Lureau <[email protected]> > >> > > >> > Use more idiomatic glib/auto-style code. > >> > > >> > Signed-off-by: Marc-André Lureau <[email protected]> > >> > >> This is a bit of an improvement, but by its own, it's a rather weak > >> justification for the previous patch. Do you have more uses of > >> g_autoptr in the pipe? > > > > > > There are a lot of similar g_auto cleanups to be done in qemu code > > base for QObject types. But I started with those tests, because they > > use a pretty unorthodox free_all pattern and that shouldn't be > > repeated. > > Would it make sense to add this the list of bite-sized tasks? >
Yes, g_auto cleanup is already covered: https://wiki.qemu.org/Contribute/BiteSizedTasks#Code_Modernization
