John Snow <js...@redhat.com> writes:
> On Thu, Mar 24, 2022 at 1:50 PM Victor Toso <victort...@redhat.com> wrote:
>>
>> * qom-path is not optional
List of one item. Recommend to scratch '* '. Slightly less terse, like
"Event data member @qom-path is not optional" wouldn't hurt.
>>
>> Signed-off-by: Victor Toso <victort...@redhat.com>
>> ---
>> qapi/machine.json | 3 ++-
>> 1 file changed, 2 insertions(+), 1 deletion(-)
>>
>> diff --git a/qapi/machine.json b/qapi/machine.json
>> index 42fc68403d..9c460ec450 100644
>> --- a/qapi/machine.json
>> +++ b/qapi/machine.json
>> @@ -1356,7 +1356,8 @@
>> # Example:
>> #
>> # <- { "event": "MEMORY_DEVICE_SIZE_CHANGE",
>> -# "data": { "id": "vm0", "size": 1073741824},
>> +# "data": { "id": "vm0", "size": 1073741824,
>> +# "qom-path": "/machine/unattached/device[2]" },
>> # "timestamp": { "seconds": 1588168529, "microseconds": 201316 } }
>> #
>> ##
>> --
>> 2.35.1
>>
>
> I'll just assume this is a realistic qom-path and not actually try to check 😅
I suppose a machine could exist where this path leads to a suitable
device.
> Reviewed-by: John Snow <js...@redhat.com>
Reviewed-by: Markus Armbruster <arm...@redhat.com>
