Sorry, Didn't notice this, as it was on v4 patch emails. I assume since there is no other follow up after a week, CI jobs are not being updated and I should change samples to use .insn. I will try to get this out tomorrow.
Thanks, - David Miller On Wed, Mar 23, 2022 at 1:13 PM Thomas Huth <th...@redhat.com> wrote: > > On 22/03/2022 11.31, Thomas Huth wrote: > > On 22/03/2022 09.53, David Hildenbrand wrote: > >> On 22.03.22 01:04, David Miller wrote: > > [...] > >>> diff --git a/tests/tcg/s390x/Makefile.target > >>> b/tests/tcg/s390x/Makefile.target > >>> index 8c9b6a13ce..921a056dd1 100644 > >>> --- a/tests/tcg/s390x/Makefile.target > >>> +++ b/tests/tcg/s390x/Makefile.target > >>> @@ -16,6 +16,14 @@ TESTS+=shift > >>> TESTS+=trap > >>> TESTS+=signals-s390x > >>> +VECTOR_TESTS=vxeh2_vs > >>> +VECTOR_TESTS+=vxeh2_vcvt > >>> +VECTOR_TESTS+=vxeh2_vlstr > >>> + > >>> +TESTS+=$(VECTOR_TESTS) > >>> + > >>> +$(VECTOR_TESTS): CFLAGS+=-march=z15 -O2 > >> > >> @Thomas, will that survive our test framework already, or do we have to > >> wait for the debain11 changes? > > > > Alex' update to the container has already been merged: > > > > https://gitlab.com/qemu-project/qemu/-/commit/89767579cad2e371b > > > > ... and seems like it's working in Travis on s390x, too: > > > > https://app.travis-ci.com/github/huth/qemu/jobs/564188977#L12797 > > > > ... so it seems like it should be OK now (considering that we drop support > > for the old Ubuntu version 18.04 in QEMU 7.1, too). > > Looks like I spoke a little bit too soon - some of the CI pipelines are > still using Debian 10 for running the TCG tests, and they are failing with > these patches applied: > > https://gitlab.com/thuth/qemu/-/jobs/2238422870#L3499 > > Thus we either need to update the CI jobs to use Debian 11, or use > handcrafted instruction opcodes here again... > > Thomas >