On Mon, Apr 04, 2022 at 09:37:10AM +0100, Daniel P. Berrangé wrote: > On Sun, Apr 03, 2022 at 10:59:50PM +0800, Gavin Shan wrote: > > This adds cluster-id in CPU instance properties, which will be used > > by arm/virt machine. Besides, the cluster-id is also verified or > > dumped in various spots: > > > > * hw/core/machine.c::machine_set_cpu_numa_node() to associate > > CPU with its NUMA node. > > > > * hw/core/machine.c::machine_numa_finish_cpu_init() to associate > > CPU with NUMA node when no default association isn't provided. > > > > * hw/core/machine-hmp-cmds.c::hmp_hotpluggable_cpus() to dump > > cluster-id. > > > > Signed-off-by: Gavin Shan <gs...@redhat.com> > > --- > > hw/core/machine-hmp-cmds.c | 4 ++++ > > hw/core/machine.c | 16 ++++++++++++++++ > > qapi/machine.json | 6 ++++-- > > 3 files changed, 24 insertions(+), 2 deletions(-) > > Missing changes to hw/core/machine-smp.c similar to 'dies' in that > file. > > When 'dies' was added we added a 'dies_supported' flag, so we could > reject use of 'dies' when it was not supported - which is everywhere > except i386 target. > > We need the same for 'clusters_supported' machine property since > AFAICT only the arm 'virt' machine is getting supported in this > series.
Oh, actually I'm mixing up cluster-id and clusters - the latter is already supported. With regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|