Re: [PATCH v2 1/2] pcie: Don't try triggering a LSI when not defined

[Daniel Henrique Barboza]

On 4/8/22 10:13, Frederic Barrat wrote:

This patch skips [de]asserting a LSI interrupt if the device doesn't
have any LSI defined. Doing so would trigger an assert in
pci_irq_handler().

The PCIE root port implementation in qemu requests a LSI (INTA), but a
subclass may want to change that behavior since it's a valid
configuration. For example on the POWER8/POWER9/POWER10 systems, the
root bridge doesn't request any LSI.

Signed-off-by: Frederic Barrat <fbar...@linux.ibm.com>
---

Reviewed-by: Daniel Henrique Barboza <danielhb...@gmail.com>

  hw/pci/pcie.c     | 5 +++--
  hw/pci/pcie_aer.c | 2 +-
  2 files changed, 4 insertions(+), 3 deletions(-)

diff --git a/hw/pci/pcie.c b/hw/pci/pcie.c
index 67a5d67372..68a62da0b5 100644
--- a/hw/pci/pcie.c
+++ b/hw/pci/pcie.c
@@ -353,7 +353,7 @@ static void hotplug_event_notify(PCIDevice *dev)
          msix_notify(dev, pcie_cap_flags_get_vector(dev));
      } else if (msi_enabled(dev)) {
          msi_notify(dev, pcie_cap_flags_get_vector(dev));
-    } else {
+    } else if (pci_intx(dev) != -1) {
          pci_set_irq(dev, dev->exp.hpev_notified);
      }
  }
@@ -361,7 +361,8 @@ static void hotplug_event_notify(PCIDevice *dev)
  static void hotplug_event_clear(PCIDevice *dev)
  {
      hotplug_event_update_event_status(dev);
-    if (!msix_enabled(dev) && !msi_enabled(dev) && !dev->exp.hpev_notified) {
+    if (!msix_enabled(dev) && !msi_enabled(dev) && pci_intx(dev) != -1 &&
+        !dev->exp.hpev_notified) {
          pci_irq_deassert(dev);
      }
  }
diff --git a/hw/pci/pcie_aer.c b/hw/pci/pcie_aer.c
index e1a8a88c8c..92bd0530dd 100644
--- a/hw/pci/pcie_aer.c
+++ b/hw/pci/pcie_aer.c
@@ -290,7 +290,7 @@ static void pcie_aer_root_notify(PCIDevice *dev)
          msix_notify(dev, pcie_aer_root_get_vector(dev));
      } else if (msi_enabled(dev)) {
          msi_notify(dev, pcie_aer_root_get_vector(dev));
-    } else {
+    } else if (pci_intx(dev) != -1) {
          pci_irq_assert(dev);
      }
  }