On Wed, Apr 20, 2022 at 7:45 PM Paolo Bonzini <pbonz...@redhat.com> wrote:
> tcg_interpreter is never written, it is purely a meson option;
> trace_backends is never read.
>
> And SeaBIOS is only build from the source tree with roms/Makefile,
> so the config.mak file is unused.
>
> Signed-off-by: Paolo Bonzini <pbonz...@redhat.com>
>
oh, that could easily be splitted, but looks good to me:
Reviewed-by: Marc-André Lureau <marcandre.lur...@redhat.com>
> ---
> configure | 24 ------------------------
> 1 file changed, 24 deletions(-)
>
> diff --git a/configure b/configure
> index 7c08c18358..2fc860ed9a 100755
> --- a/configure
> +++ b/configure
> @@ -320,7 +320,6 @@ linux_user=""
> bsd_user=""
> pkgversion=""
> pie=""
> -trace_backends="log"
> trace_file="trace"
> opengl="$default_feature"
> coroutine=""
> @@ -391,7 +390,6 @@ for opt do
> cross_cc_vars="$cross_cc_vars
> cross_cc_cflags_${cc_arch}"
> ;;
> --cross-cc-*) cc_arch=${opt#--cross-cc-}; cc_arch=${cc_arch%%=*}
> - cc_archs="$cc_archs $cc_arch"
> eval "cross_cc_${cc_arch}=\$optarg"
> cross_cc_vars="$cross_cc_vars cross_cc_${cc_arch}"
> ;;
> @@ -2881,9 +2879,6 @@ fi
> if test "$vhost_user_fs" = "yes" ; then
> echo "CONFIG_VHOST_USER_FS=y" >> $config_host_mak
> fi
> -if test "$tcg" = "enabled" -a "$tcg_interpreter" = "true" ; then
> - echo "CONFIG_TCG_INTERPRETER=y" >> $config_host_mak
> -fi
>
> if test "$opengl" = "yes" ; then
> echo "CONFIG_OPENGL=y" >> $config_host_mak
> @@ -3025,7 +3020,6 @@ LINKS="Makefile"
> LINKS="$LINKS tests/tcg/Makefile.target"
> LINKS="$LINKS pc-bios/optionrom/Makefile"
> LINKS="$LINKS pc-bios/s390-ccw/Makefile"
> -LINKS="$LINKS roms/seabios/Makefile"
> LINKS="$LINKS pc-bios/qemu-icon.bmp"
> LINKS="$LINKS .gdbinit scripts" # scripts needed by relative path in
> .gdbinit
> LINKS="$LINKS tests/avocado tests/data"
> @@ -3060,24 +3054,6 @@ done
> export target_list source_path use_containers cpu
> $source_path/tests/tcg/configure.sh)
>
> -# temporary config to build submodules
> -if test -f $source_path/roms/seabios/Makefile; then
> - for rom in seabios; do
> - config_mak=roms/$rom/config.mak
> - echo "# Automatically generated by configure - do not modify" >
> $config_mak
> - echo "SRC_PATH=$source_path/roms/$rom" >> $config_mak
> - echo "AS=$as" >> $config_mak
> - echo "CCAS=$ccas" >> $config_mak
> - echo "CC=$cc" >> $config_mak
> - echo "BCC=bcc" >> $config_mak
> - echo "CPP=$cpp" >> $config_mak
> - echo "OBJCOPY=objcopy" >> $config_mak
> - echo "IASL=$iasl" >> $config_mak
> - echo "LD=$ld" >> $config_mak
> - echo "RANLIB=$ranlib" >> $config_mak
> - done
> -fi
> -
> config_mak=pc-bios/optionrom/config.mak
> echo "# Automatically generated by configure - do not modify" >
> $config_mak
> echo "TOPSRC_DIR=$source_path" >> $config_mak
> --
> 2.35.1
>
>
>
>
--
Marc-André Lureau
