On Wed, Apr 20, 2022 at 12:43:39PM +0100, Daniel P. Berrangé wrote: > > static void test_baddest(void) > > { > > MigrateStart args = { > > @@ -2176,6 +2219,12 @@ int main(int argc, char **argv) > > > > qtest_add_func("/migration/postcopy/unix", test_postcopy); > > qtest_add_func("/migration/postcopy/recovery", test_postcopy_recovery); > > + qtest_add_func("/migration/postcopy/preempt/unix", > > test_postcopy_preempt); > > + qtest_add_func("/migration/postcopy/preempt/recovery", > > + test_postcopy_preempt_recovery); > > + qtest_add_func("/migration/postcopy/preempt/tls", > > test_postcopy_preempt_tls); > > + qtest_add_func("/migration/postcopy/preempt/tls+recovery", > > + test_postcopy_preempt_all); > > On test naming again I think we want these four tests to have names > > /migration/postcopy/preempt/plain > /migration/postcopy/preempt/tls/psk > /migration/postcopy/preempt/recovery/plain > /migration/postcopy/preempt/recovery/tls/psk
Well to think it again, logically if we prefer to spell out tls/psk, then we may also want to spell out preempt/unix because of the same reason.. Similarly to all the vanilla postcopy/* tests, where if we keep tls/psk, then we should keep postcopy/unix rather than postcopy/plain. But let's not bother much with it.. I'll apply all the changes above in the new version. Thanks a lot for reviewing the series, -- Peter Xu