On Tue, 5 Apr 2022 at 23:38, Hao Wu <wuhao...@google.com> wrote: > > Signed-off-by: Hao Wu <wuhao...@google.com> > Reviwed-by: Patrick Venture <vent...@google.com> > --- > hw/arm/meson.build | 2 +- > hw/arm/npcm8xx_boards.c | 257 +++++++++++++++++++++++++++++++++++++++ > include/hw/arm/npcm8xx.h | 20 +++ > 3 files changed, 278 insertions(+), 1 deletion(-) > create mode 100644 hw/arm/npcm8xx_boards.c
> --- /dev/null > +++ b/hw/arm/npcm8xx_boards.c > @@ -0,0 +1,257 @@ > +/* > + * Machine definitions for boards featuring an NPCM8xx SoC. > + * > + * Copyright 2022 Google LLC > + * > + * This program is free software; you can redistribute it and/or modify it > + * under the terms of the GNU General Public License as published by the > + * Free Software Foundation; either version 2 of the License, or > + * (at your option) any later version. > + * > + * This program is distributed in the hope that it will be useful, but > WITHOUT > + * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or > + * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License > + * for more details. > + */ > + > +#include "qemu/osdep.h" > + > +#include "chardev/char.h" > +#include "hw/arm/npcm8xx.h" > +#include "hw/core/cpu.h" > +#include "hw/loader.h" > +#include "hw/qdev-core.h" > +#include "hw/qdev-properties.h" > +#include "qapi/error.h" > +#include "qemu-common.h" Don't include qemu-common.h unless you really need it (if you rebase on current head-of-git you almost certainly don't, as it now contains only a very few things, most of its previous contents having been split into more specific header files). There are some patches in flight which rename/delete it entirely, so if you don't #include it you'll avoid a conflict when they land. thanks -- PMM