Re: [PATCH] target/arm: Disable cryptographic instructions when neon is disabled

[Richard Henderson]

On 4/26/22 05:42, Damien Hedde wrote:

@@ -1587,6 +1587,9 @@ static void arm_cpu_realizefn(DeviceState *dev, Error 
**errp)
          unset_feature(env, ARM_FEATURE_NEON);

t = cpu->isar.id_aa64isar0;

+        t = FIELD_DP64(t, ID_AA64ISAR0, AES, 0);
+        t = FIELD_DP64(t, ID_AA64ISAR0, SHA1, 0);
+        t = FIELD_DP64(t, ID_AA64ISAR0, SHA2, 0);
          t = FIELD_DP64(t, ID_AA64ISAR0, DP, 0);
          cpu->isar.id_aa64isar0 = t;

Missing SHA3, SM3, SM4.  Otherwise, good catch, thanks.

r~