Hi Daniel
On Tue, Apr 26, 2022 at 1:27 PM <marcandre.lur...@redhat.com> wrote:
> From: Marc-André Lureau <marcandre.lur...@redhat.com>
>
> Hi,
>
> v2:
> - add patches to replace pipe() with g_unix_open_pipe()
>
Since you suggested this change, could you review the "replace pipe()"
patches?
thanks!
> - add patch "Replace fcntl(0_NONBLOCK) with g_unix_set_fd_nonblocking()"
> - add patches to cleanup qemu_*block() usage (see "util: rename
> qemu_*block()
> socket functions" commit message)
> - fix lost braces during code move
> - replace TRUE/FALSE with true/false
> - add reviewed/ack-by tags
>
> Marc-André Lureau (26):
> Use QEMU_SANITIZE_THREAD
> Use QEMU_SANITIZE_ADDRESS
> include: move qemu_*_exec_dir() to cutils
> util/win32: simplify qemu_get_local_state_dir()
> tests: move libqtest.h back under qtest/
> libqtest: split QMP part in libqmp
> tests: make libqmp buildable for win32
> Use g_unix_set_fd_nonblocking()
> block: move fcntl_setfl()
> Replace qemu_pipe() with g_unix_open_pipe()
> util: replace pipe()+cloexec with g_unix_open_pipe()
> qga: replace pipe() with g_unix_open_pipe(CLOEXEC)
> tests: replace pipe() with g_unix_open_pipe(CLOEXEC)
> os-posix: replace pipe()+cloexec with g_unix_open_pipe(CLOEXEC)
> virtiofsd: replace pipe() with g_unix_open_pipe(CLOEXEC)
> io: replace pipe() with g_unix_open_pipe(CLOEXEC)
> Replace fcntl(0_NONBLOCK) with g_unix_set_fd_nonblocking()
> io: make qio_channel_command_new_pid() static
> chardev: replace qemu_set_nonblock()
> io: replace qemu_set{_non}block()
> qga: replace qemu_set_nonblock()
> hw: replace qemu_set_nonblock()
> ui: replace qemu_set_nonblock()
> net: replace qemu_set_nonblock()
> tests: replace qemu_set_nonblock()
> util: rename qemu_*block() socket functions
>
> docs/devel/qtest.rst | 2 +-
> include/io/channel-command.h | 25 --
> include/qemu/atomic.h | 8 +-
> include/qemu/cutils.h | 7 +
> include/qemu/osdep.h | 12 -
> include/qemu/sockets.h | 6 +-
> include/sysemu/os-posix.h | 2 -
> subprojects/libvhost-user/include/compiler.h | 1 +
> tests/qtest/acpi-utils.h | 2 +-
> tests/qtest/boot-sector.h | 2 +-
> tests/qtest/fuzz/fuzz.h | 2 +-
> tests/qtest/libqmp.h | 52 ++++
> tests/qtest/libqos/fw_cfg.h | 2 +-
> tests/qtest/libqos/i2c.h | 2 +-
> tests/qtest/libqos/libqos.h | 2 +-
> tests/qtest/libqos/malloc.h | 2 +-
> tests/qtest/libqos/pci.h | 2 +-
> tests/qtest/libqos/sdhci-cmd.h | 2 +-
> tests/qtest/libqtest-single.h | 2 +-
> tests/qtest/{libqos => }/libqtest.h | 29 +-
> tests/qtest/migration-helpers.h | 2 +-
> tests/qtest/tpm-emu.h | 2 +-
> block/file-posix.c | 15 +
> chardev/char-fd.c | 4 +-
> chardev/char-pty.c | 5 +-
> chardev/char-serial.c | 5 +-
> chardev/char-socket.c | 2 +-
> chardev/char-stdio.c | 5 +-
> contrib/ivshmem-server/ivshmem-server.c | 2 +-
> hw/hyperv/syndbg.c | 2 +-
> hw/input/virtio-input-host.c | 5 +-
> hw/misc/ivshmem.c | 2 +-
> hw/virtio/vhost-user.c | 2 +-
> hw/virtio/vhost-vsock.c | 11 +-
> io/channel-command.c | 46 +++-
> io/channel-file.c | 13 +-
> io/channel-socket.c | 6 +-
> net/l2tpv3.c | 2 +-
> net/socket.c | 10 +-
> net/tap-bsd.c | 4 +-
> net/tap-linux.c | 2 +-
> net/tap-solaris.c | 2 +-
> net/tap.c | 33 ++-
> os-posix.c | 3 +-
> qemu-io.c | 1 +
> qemu-nbd.c | 5 +-
> qga/channel-posix.c | 2 +-
> qga/commands-posix.c | 8 +-
> storage-daemon/qemu-storage-daemon.c | 1 +
> tests/qtest/ac97-test.c | 2 +-
> tests/qtest/ahci-test.c | 2 +-
> tests/qtest/am53c974-test.c | 2 +-
> tests/qtest/arm-cpu-features.c | 2 +-
> tests/qtest/aspeed_hace-test.c | 2 +-
> tests/qtest/boot-order-test.c | 2 +-
> tests/qtest/boot-sector.c | 2 +-
> tests/qtest/boot-serial-test.c | 2 +-
> tests/qtest/cdrom-test.c | 2 +-
> tests/qtest/dbus-display-test.c | 2 +-
> tests/qtest/dbus-vmstate-test.c | 2 +-
> tests/qtest/device-introspect-test.c | 2 +-
> tests/qtest/device-plug-test.c | 2 +-
> tests/qtest/drive_del-test.c | 2 +-
> tests/qtest/ds1338-test.c | 2 +-
> tests/qtest/e1000-test.c | 2 +-
> tests/qtest/eepro100-test.c | 2 +-
> tests/qtest/endianness-test.c | 2 +-
> tests/qtest/erst-test.c | 2 +-
> tests/qtest/es1370-test.c | 2 +-
> tests/qtest/fdc-test.c | 2 +-
> tests/qtest/fuzz-e1000e-test.c | 2 +-
> tests/qtest/fuzz-lsi53c895a-test.c | 2 +-
> tests/qtest/fuzz-megasas-test.c | 2 +-
> tests/qtest/fuzz-sb16-test.c | 2 +-
> tests/qtest/fuzz-sdcard-test.c | 2 +-
> tests/qtest/fuzz-virtio-scsi-test.c | 2 +-
> tests/qtest/fuzz-xlnx-dp-test.c | 2 +-
> tests/qtest/fuzz/fuzz.c | 3 +-
> tests/qtest/fuzz/generic_fuzz.c | 2 +-
> tests/qtest/fuzz/i440fx_fuzz.c | 2 +-
> tests/qtest/fuzz/qos_fuzz.c | 2 +-
> tests/qtest/fuzz/virtio_blk_fuzz.c | 2 +-
> tests/qtest/fuzz/virtio_net_fuzz.c | 4 +-
> tests/qtest/fuzz/virtio_scsi_fuzz.c | 2 +-
> tests/qtest/fw_cfg-test.c | 2 +-
> tests/qtest/hd-geo-test.c | 2 +-
> tests/qtest/hexloader-test.c | 2 +-
> tests/qtest/ide-test.c | 2 +-
> tests/qtest/ipoctal232-test.c | 2 +-
> tests/qtest/ivshmem-test.c | 7 +-
> tests/qtest/libqmp.c | 258 ++++++++++++++++++
> .../libqos/aarch64-xlnx-zcu102-machine.c | 2 +-
> tests/qtest/libqos/ahci.c | 2 +-
> tests/qtest/libqos/arm-imx25-pdk-machine.c | 2 +-
> tests/qtest/libqos/arm-n800-machine.c | 2 +-
> tests/qtest/libqos/arm-raspi2-machine.c | 2 +-
> tests/qtest/libqos/arm-sabrelite-machine.c | 2 +-
> tests/qtest/libqos/arm-smdkc210-machine.c | 2 +-
> tests/qtest/libqos/arm-virt-machine.c | 2 +-
> .../qtest/libqos/arm-xilinx-zynq-a9-machine.c | 2 +-
> tests/qtest/libqos/e1000e.c | 2 +-
> tests/qtest/libqos/fw_cfg.c | 2 +-
> tests/qtest/libqos/i2c-imx.c | 2 +-
> tests/qtest/libqos/i2c-omap.c | 2 +-
> tests/qtest/libqos/i2c.c | 2 +-
> tests/qtest/libqos/libqos.c | 2 +-
> tests/qtest/libqos/pci-pc.c | 2 +-
> tests/qtest/libqos/pci-spapr.c | 2 +-
> tests/qtest/libqos/ppc64_pseries-machine.c | 2 +-
> tests/qtest/libqos/qgraph.c | 2 +-
> tests/qtest/libqos/qos_external.c | 2 +-
> tests/qtest/libqos/rtas.c | 2 +-
> tests/qtest/libqos/sdhci-cmd.c | 2 +-
> tests/qtest/libqos/sdhci.c | 2 +-
> tests/qtest/libqos/tpci200.c | 2 +-
> tests/qtest/libqos/usb.c | 2 +-
> tests/qtest/libqos/vhost-user-blk.c | 2 +-
> tests/qtest/libqos/virtio-9p.c | 2 +-
> tests/qtest/libqos/virtio-balloon.c | 2 +-
> tests/qtest/libqos/virtio-blk.c | 2 +-
> tests/qtest/libqos/virtio-iommu.c | 2 +-
> tests/qtest/libqos/virtio-mmio.c | 2 +-
> tests/qtest/libqos/virtio-net.c | 2 +-
> tests/qtest/libqos/virtio-pci.c | 2 +-
> tests/qtest/libqos/virtio-rng.c | 2 +-
> tests/qtest/libqos/virtio-scsi.c | 2 +-
> tests/qtest/libqos/virtio-serial.c | 2 +-
> tests/qtest/libqos/virtio.c | 2 +-
> tests/qtest/libqos/x86_64_pc-machine.c | 2 +-
> tests/qtest/libqtest.c | 207 +-------------
> tests/qtest/lpc-ich9-test.c | 2 +-
> tests/qtest/m48t59-test.c | 2 +-
> tests/qtest/machine-none-test.c | 2 +-
> tests/qtest/megasas-test.c | 2 +-
> tests/qtest/microbit-test.c | 2 +-
> tests/qtest/migration-test.c | 2 +-
> tests/qtest/modules-test.c | 2 +-
> tests/qtest/ne2000-test.c | 2 +-
> tests/qtest/npcm7xx_adc-test.c | 2 +-
> tests/qtest/npcm7xx_pwm-test.c | 2 +-
> tests/qtest/npcm7xx_sdhci-test.c | 2 +-
> tests/qtest/npcm7xx_smbus-test.c | 2 +-
> tests/qtest/npcm7xx_watchdog_timer-test.c | 2 +-
> tests/qtest/numa-test.c | 2 +-
> tests/qtest/nvme-test.c | 2 +-
> tests/qtest/pca9552-test.c | 2 +-
> tests/qtest/pci-test.c | 2 +-
> tests/qtest/pcnet-test.c | 2 +-
> tests/qtest/pflash-cfi02-test.c | 2 +-
> tests/qtest/pnv-xscom-test.c | 2 +-
> tests/qtest/prom-env-test.c | 2 +-
> tests/qtest/pvpanic-pci-test.c | 2 +-
> tests/qtest/pvpanic-test.c | 2 +-
> tests/qtest/pxe-test.c | 2 +-
> tests/qtest/q35-test.c | 2 +-
> tests/qtest/qmp-cmd-test.c | 2 +-
> tests/qtest/qmp-test.c | 2 +-
> tests/qtest/qom-test.c | 2 +-
> tests/qtest/rtas-test.c | 2 +-
> tests/qtest/sdhci-test.c | 2 +-
> tests/qtest/spapr-phb-test.c | 2 +-
> tests/qtest/tco-test.c | 2 +-
> tests/qtest/test-filter-mirror.c | 2 +-
> tests/qtest/test-filter-redirector.c | 2 +-
> tests/qtest/test-hmp.c | 2 +-
> tests/qtest/tpm-crb-swtpm-test.c | 2 +-
> tests/qtest/tpm-tis-device-swtpm-test.c | 2 +-
> tests/qtest/tpm-tis-swtpm-test.c | 2 +-
> tests/qtest/tpm-util.c | 2 +-
> tests/qtest/tulip-test.c | 2 +-
> tests/qtest/vhost-user-test.c | 4 +-
> tests/qtest/virtio-net-failover.c | 2 +-
> tests/qtest/virtio-rng-test.c | 2 +-
> tests/qtest/virtio-test.c | 2 +-
> tests/qtest/vmgenid-test.c | 2 +-
> tests/qtest/vmxnet3-test.c | 2 +-
> tests/qtest/wdt_ib700-test.c | 2 +-
> tests/qtest/xlnx-can-test.c | 2 +-
> tests/unit/socket-helpers.c | 2 +-
> tests/unit/test-crypto-tlssession.c | 8 +-
> tests/unit/test-io-channel-file.c | 2 +-
> tests/unit/test-iov.c | 4 +-
> tests/unit/test-qga.c | 2 +-
> tools/virtiofsd/helper.c | 2 +-
> ui/input-linux.c | 5 +-
> util/compatfd.c | 5 +-
> util/coroutine-ucontext.c | 2 +-
> util/cutils.c | 108 ++++++++
> util/event_notifier-posix.c | 8 +-
> util/main-loop.c | 2 +-
> util/oslib-posix.c | 142 +---------
> util/oslib-win32.c | 61 +----
> util/vhost-user-server.c | 4 +-
> scripts/oss-fuzz/output_reproducer.py | 2 +-
> tests/qtest/libqos/meson.build | 5 +-
> tests/unit/meson.build | 2 +-
> 196 files changed, 758 insertions(+), 703 deletions(-)
> create mode 120000 subprojects/libvhost-user/include/compiler.h
> create mode 100644 tests/qtest/libqmp.h
> rename tests/qtest/{libqos => }/libqtest.h (95%)
> create mode 100644 tests/qtest/libqmp.c
>
> --
> 2.36.0
>
>
>
--
Marc-André Lureau
