> -----Original Message----- > From: Zhang, Chen > Sent: Wednesday, April 27, 2022 5:26 PM > To: Jason Wang <jasow...@redhat.com>; Paolo Bonzini > <pbonz...@redhat.com> > Cc: Li Zhijian <lizhij...@cn.fujitsu.com>; qemu-dev <qemu- > de...@nongnu.org>; Like Xu <like...@linux.intel.com> > Subject: RE: [PATCH V2 1/4] softmmu/runstate.c: add RunStateTransition > support form COLO to PRELAUNCH > > > > > -----Original Message----- > > From: Jason Wang <jasow...@redhat.com> > > Sent: Wednesday, April 27, 2022 4:57 PM > > To: Zhang, Chen <chen.zh...@intel.com> > > Cc: Li Zhijian <lizhij...@cn.fujitsu.com>; qemu-dev <qemu- > > de...@nongnu.org>; Like Xu <like...@linux.intel.com> > > Subject: Re: [PATCH V2 1/4] softmmu/runstate.c: add RunStateTransition > > support form COLO to PRELAUNCH > > > > On Fri, Apr 1, 2022 at 11:59 AM Zhang Chen <chen.zh...@intel.com> wrote: > > > > > > If the checkpoint occurs when the guest finishes restarting but has > > > not started running, the runstate_set() may reject the transition > > > from COLO to PRELAUNCH with the crash log: > > > > > > {"timestamp": {"seconds": 1593484591, "microseconds": 26605},\ > > > "event": "RESET", "data": {"guest": true, "reason": "guest-reset"}} > > > qemu-system-x86_64: invalid runstate transition: 'colo' -> 'prelaunch' > > > > > > Long-term testing says that it's pretty safe. > > > > > > Signed-off-by: Like Xu <like...@linux.intel.com> > > > Signed-off-by: Zhang Chen <chen.zh...@intel.com> > > > > I'd expect this to get ack from the relevant maintainers. > > > > The scripts/get_maintainer.pl can't find relevant maintainers for this patch. > Maybe Paolo have time to cover this simple patch related to runstate?
No news for a while, any comments for unmaintained files changes ? Ping... Thanks Chen > > Thanks > Chen > > > Thanks > > > > > --- > > > softmmu/runstate.c | 1 + > > > 1 file changed, 1 insertion(+) > > > > > > diff --git a/softmmu/runstate.c b/softmmu/runstate.c index > > > e0d869b21a..c021c56338 100644 > > > --- a/softmmu/runstate.c > > > +++ b/softmmu/runstate.c > > > @@ -127,6 +127,7 @@ static const RunStateTransition > > runstate_transitions_def[] = { > > > { RUN_STATE_RESTORE_VM, RUN_STATE_PRELAUNCH }, > > > > > > { RUN_STATE_COLO, RUN_STATE_RUNNING }, > > > + { RUN_STATE_COLO, RUN_STATE_PRELAUNCH }, > > > { RUN_STATE_COLO, RUN_STATE_SHUTDOWN}, > > > > > > { RUN_STATE_RUNNING, RUN_STATE_DEBUG }, > > > -- > > > 2.25.1 > > >