Thomas Huth <th...@redhat.com> writes: > These parameters are in the way for further refactoring (since they > use an underscore in the name which is forbidden in QAPI), so let's > remove these now that their deprecation period is over.
Forbidden, but there's an exception mechanism, so this reason isn't compelling. I believe the actual reason is they are "too ugly and inflexible to drag them along into the QAPI world" (your words). Suggest: Dropping these deprecated parameters now simplifies further refactoring. > Reviewed-by: Daniel P. Berrangé <berra...@redhat.com> > Signed-off-by: Thomas Huth <th...@redhat.com> Patch looks good to me, so Reviewed-by: Markus Armbruster <arm...@redhat.com>
