On Thu, May 26, 2022 at 4:17 PM John Snow <js...@redhat.com> wrote: >> > - $(call quiet-command, \ >> > - $(TESTS_PYTHON) -m pip -q --disable-pip-version-check install >> > \ >> > - -r $(TESTS_VENV_REQ), PIP, $(TESTS_VENV_REQ)) >> > + $(call quiet-command, $(PYTHON) -m venv $@, VENV, $@) >> > + $(call quiet-venv-pip,install -r $(TESTS_VENV_REQ)) >> > $(call quiet-command, touch $@) >> > >> > $(TESTS_RESULTS_DIR): >> >> Sooner or later I'd like quiet-command to be changed to English >> descriptions like the ones currently emitted during the ninja build, but >> stuff for later. > > If it helps, this is a bit of a stopgap on the way to the configure-driven > version; ideally this goes away by the end of this little project. > > (I just thought it made the recipes read nicer and reduced the chance for > anyone else getting the pip flags wrong in the interim.)
Don't worry, you're at least consistent with the current way the macros work. Paolo
