Am 30. Mai 2022 11:38:30 UTC schrieb "Philippe Mathieu-Daudé" <f4...@amsat.org>:
>On 28/5/22 21:20, Bernhard Beschow wrote:
>> Found-by: Peter Maydell <peter.mayd...@linaro.org>
>
>I suppose you refer to this thread:
>https://lore.kernel.org/qemu-devel/CAFEAcA_y69=iXMH75dHeNkxMa038Z7Xk63GW9fdcAFHJSWS=s...@mail.gmail.com/
Yes, correct.
>I'm going to change the tag to "Reported-by".
I'll take care of this in v4.
>Reviewed-by: Philippe Mathieu-Daudé <f4...@amsat.org>
>
>> Signed-off-by: Bernhard Beschow <shen...@gmail.com>
>> ---
>> hw/isa/piix4.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/hw/isa/piix4.c b/hw/isa/piix4.c
>> index 9a6d981037..1d04fb6a55 100644
>> --- a/hw/isa/piix4.c
>> +++ b/hw/isa/piix4.c
>> @@ -224,7 +224,7 @@ static void piix4_init(Object *obj)
>> {
>> PIIX4State *s = PIIX4_PCI_DEVICE(obj);
>> - object_initialize(&s->rtc, sizeof(s->rtc), TYPE_MC146818_RTC);
>> + object_initialize_child(obj, "rtc", &s->rtc, TYPE_MC146818_RTC);
>> }
>> static void piix4_class_init(ObjectClass *klass, void *data)
