Am 30. Mai 2022 11:27:07 UTC schrieb "Philippe Mathieu-Daudé" <philippe.mathieu.da...@gmail.com>: >From: Philippe Mathieu-Daudé <f4...@amsat.org> > >This series moves the outstanding logic from piix4_pm_init() into >the relevant instance init() and realize() functions, changes the >IRQs to use qdev gpios, and then finally removes the now-unused >piix4_pm_initfn() function. > >v2: >- Addressed Ani & Bernhard review comments
Patch 4 still introduces the redundant include in acpi/piix4.c, and perhaps all includes already included in the new piix4.h could still be removed alrogether [1]. Anyway: Reviewed-by: Bernhard Beschow <shen...@gmail.com> [1] https://lists.nongnu.org/archive/html/qemu-devel/2022-05/msg05756.html > >If no further comments I plan to queue this via mips-next end of >this week. > >Regards, > >Phil. > >Mark Cave-Ayland (11): > hw/acpi/piix4: move xen_enabled() logic from piix4_pm_init() to > piix4_pm_realize() > hw/acpi/piix4: change smm_enabled from int to bool > hw/acpi/piix4: convert smm_enabled bool to qdev property > hw/acpi/piix4: move PIIX4PMState into separate piix4.h header > hw/acpi/piix4: alter piix4_pm_init() to return PIIX4PMState > hw/acpi/piix4: rename piix4_pm_init() to piix4_pm_initfn() > hw/acpi/piix4: use qdev gpio to wire up sci_irq > hw/acpi/piix4: use qdev gpio to wire up smi_irq > hw/i386/pc_piix: create PIIX4_PM device directly instead of using > piix4_pm_initfn() > hw/isa/piix4.c: create PIIX4_PM device directly instead of using > piix4_pm_initfn() > hw/acpi/piix4: remove unused piix4_pm_initfn() function > > hw/acpi/piix4.c | 77 ++++++----------------------------- > hw/i386/acpi-build.c | 1 + > hw/i386/pc_piix.c | 16 +++++--- > hw/isa/piix4.c | 11 +++-- > include/hw/acpi/piix4.h | 75 ++++++++++++++++++++++++++++++++++ > include/hw/southbridge/piix.h | 6 --- > 6 files changed, 107 insertions(+), 79 deletions(-) > create mode 100644 include/hw/acpi/piix4.h >
