On 6/3/22 04:18, Andrew Jones wrote:
The max cpu type is the best default cpu type for tests to use
when specifying the cpu type for AArch64 mach-virt. Switch all
tests to it.

Cc: Alex Bennée <alex.ben...@linaro.org>
Signed-off-by: Andrew Jones <drjo...@redhat.com>

For avoidance of doubt, copying v1 comment to v2:

diff --git a/tests/avocado/replay_kernel.py b/tests/avocado/replay_kernel.py
index 0b2b0dc692b1..c19022ea977d 100644
--- a/tests/avocado/replay_kernel.py
+++ b/tests/avocado/replay_kernel.py
@@ -147,7 +147,7 @@ def test_aarch64_virt(self):
          """
          :avocado: tags=arch:aarch64
          :avocado: tags=machine:virt
-        :avocado: tags=cpu:cortex-a53
+        :avocado: tags=cpu:max
          """
          kernel_url = ('https://archives.fedoraproject.org/pub/archive/fedora'
                        
'/linux/releases/29/Everything/aarch64/os/images/pxeboot'

This will *not* work without further changes. Fedora 29 will is old, and will not boot a cpu with FEAT_LPA2 enabled.

See 11593544df6f ("tests/avocado: update aarch64_virt test to exercise -cpu 
max")

Which makes me wonder if you've actually tested this?


r~

Reply via email to