On Sun, 22 May 2022 at 19:19, Mark Cave-Ayland <mark.cave-ayl...@ilande.co.uk> wrote: > > This exposes the I8042_MMIO device to the caller to allow the register memory > region to be mapped outside of i8042_mm_init(). > > Signed-off-by: Mark Cave-Ayland <mark.cave-ayl...@ilande.co.uk>
Reviewed-by: Peter Maydell <peter.mayd...@linaro.org> I'm not sure where best to put this review comment in the patchseries, so I'll just note it here: I see that at the end of the series we end up with an i8042_mm_init() which is just "create a device with qdev_new, set properties, realize it, and connect its gpio lines". Since that function has exactly one callsite (in hw/mips/jazz.c) I think we should add a patch on the end that gets rid of i8042_mm_init() entirely in favour of the board doing all the "create and wire up device" code inline. thanks -- PMM
