On Sun, 22 May 2022 at 19:20, Mark Cave-Ayland <mark.cave-ayl...@ilande.co.uk> wrote: > > This is in preparation for handling vmstate_register() within the device. > > Signed-off-by: Mark Cave-Ayland <mark.cave-ayl...@ilande.co.uk> > --- > hw/input/lasips2.c | 17 ++++++++++++++++- > include/hw/input/lasips2.h | 1 + > 2 files changed, 17 insertions(+), 1 deletion(-)
> static const TypeInfo lasips2_info = { > .name = TYPE_LASIPS2, > .parent = TYPE_SYS_BUS_DEVICE, > .instance_init = lasips2_init, > - .instance_size = sizeof(LASIPS2State) > + .instance_size = sizeof(LASIPS2State), > + .class_init = lasips2_class_init If you put the trailing comma at the end of this last line, then the next person who comes along to add a new line at the end of the struct won't have to edit the preceding line to add the comma. Anyway, as a code change this is fine, so Reviewed-by: Peter Maydell <peter.mayd...@linaro.org> but as I note in review of patch 44 it would be better to avoid vmstate_register(), in which case we don't need the property. thanks -- PMM