On 6/18/22 01:07, Iris Chen wrote:
Hey everyone,

I discovered that some of the tests in tests/qtest/aspeed_smc-test.c were
failing when run in isolation due to dependencies between the tests. For
example, one test would test the reading of a block of memory written
in the test before it.

I think it would make sense to add flash_reset() between running the
tests and make sure the tests do not rely on each other. Thus, I have
made changes to the tests so that they now pass individually with
no dependencies on each other.

Good. Thanks for doing that.

Please add to your .gitconfig :

  [sendemail]
          thread = true

Emails are not correctly threaded. At least on my side.

Thanks,

C.


Thanks,
Iris

Iris Chen (1):
   hw: m25p80: fixing individual test failure when tests are running in
     isolation

  tests/qtest/aspeed_smc-test.c | 74 +++++++++++++++++++++++++++++------
  1 file changed, 63 insertions(+), 11 deletions(-)

--
2.30.2


Reply via email to