On Sat, 11 Jun 2022 at 16:44, Mark Cave-Ayland <mark.cave-ayl...@ilande.co.uk> wrote: > > On 10/06/2022 08:17, Mark Cave-Ayland wrote: > > > On 09/06/2022 12:18, Peter Maydell wrote: > >> If you find yourself #defining names for IRQ lines then this is > >> probably a sign you should be using named GPIO lines :-) > > > > Yeah that's something I've done a few times here, mainly to have just one > > "set IRQ" > > function rather a separate one for both keyboard and mouse. It takes a bit > > more work, > > but I can certainly separate them out. > > Looking at this again, the gpio being defined here actually is the (only) > lasips2 > output IRQ, and so should be left unnamed. > > The reason for adding LASIPS2_IRQ was so that the gpio connection process > looked like: > > qdev_connect_gpio_out(dev, LASIPS2_IRQ, irq); > > instead of: > > qdev_connect_gpio_out(dev, 0, irq); > > Would you still prefer for me to simply hardcode 0 here and drop the > LASIPS2_IRQ > define in this case since there is only one output IRQ?
Well, I think that "unnamed GPIO out" lines should be for actual GPIO lines, ie on a GPIO controller or similar. If you want an outbound IRQ line and don't want to name it, that's what sysbus IRQ lines do. Otherwise, name the GPIO line. thanks -- PMM