On Mon, 20 Jun 2022 at 19:29, Richard Henderson <richard.hender...@linaro.org> wrote: > > This is SMOPA, SUMOPA, USMOPA_s, UMOPA, for both Int8 and Int16. > > Signed-off-by: Richard Henderson <richard.hender...@linaro.org> > --- > target/arm/helper-sme.h | 16 ++++++++ > target/arm/sme.decode | 10 +++++ > target/arm/sme_helper.c | 82 ++++++++++++++++++++++++++++++++++++++ > target/arm/translate-sme.c | 14 +++++++ > 4 files changed, 122 insertions(+)
> /* TODO: FEAT_EBF16 */ > TRANS_FEAT(BFMOPA, aa64_sme, do_outprod, a, MO_32, gen_helper_sme_bfmopa) > + > +TRANS_FEAT(SMOPA_s, aa64_sme, do_outprod, a, MO_32, gen_helper_sme_smopa_s) > +TRANS_FEAT(UMOPA_s, aa64_sme, do_outprod, a, MO_32, gen_helper_sme_umopa_s) > +TRANS_FEAT(SUMOPA_s, aa64_sme, do_outprod, a, MO_32, gen_helper_sme_sumopa_s) > +TRANS_FEAT(USMOPA_s, aa64_sme, do_outprod, a, MO_32, gen_helper_sme_usmopa_s) > + > +TRANS_FEAT(SMOPA_d, aa64_sme_i16i64, do_outprod, > + a, MO_64, gen_helper_sme_smopa_d) > +TRANS_FEAT(UMOPA_d, aa64_sme_i16i64, do_outprod, > + a, MO_64, gen_helper_sme_umopa_d) > +TRANS_FEAT(SUMOPA_d, aa64_sme_i16i64, do_outprod, > + a, MO_64, gen_helper_sme_sumopa_d) > +TRANS_FEAT(USMOPA_d, aa64_sme_i16i64, do_outprod, > + a, MO_64, gen_helper_sme_usmopa_d) I think this is one of those places where I'd say that wrapping the lines reads worse than not wrapping them. But either way Reviewed-by: Peter Maydell <peter.mayd...@linaro.org> thanks -- PMM