Re: [PATCH v2 6/7] hw/arm/aspeed: firework: Add Thermal Diodes

[Cédric Le Goater]

On 6/27/22 17:47, Jae Hyun Yoo wrote:

From: Maheswara Kurapati <quic_mkura...@quicinc.com>

Add Thermal Diodes for Firework machine.

Signed-off-by: Maheswara Kurapati <quic_mkura...@quicinc.com>
Signed-off-by: Jae Hyun Yoo <quic_jaeh...@quicinc.com>

Reviewed-by: Cédric Le Goater <c...@kaod.org>

Thanks,

C.

---
Changes in v2:
* Refined code to avoid retouching by the next patch. (Joel)

  hw/arm/aspeed.c | 10 ++++++++++
  1 file changed, 10 insertions(+)

diff --git a/hw/arm/aspeed.c b/hw/arm/aspeed.c
index 9c07db70f2fc..cfc322ee30e9 100644
--- a/hw/arm/aspeed.c
+++ b/hw/arm/aspeed.c
@@ -1002,12 +1002,22 @@ static void qcom_dc_scm_bmc_i2c_init(AspeedMachineState 
*bmc)
  static void qcom_dc_scm_firework_i2c_init(AspeedMachineState *bmc)
  {
      AspeedSoCState *soc = &bmc->soc;
+    I2CSlave *therm_mux;

/* Create the generic DC-SCM hardware */

      qcom_dc_scm_bmc_i2c_init(bmc);

/* Now create the Firework specific hardware */ + /* I2C8 Thermal Diodes*/

+    therm_mux = i2c_slave_create_simple(aspeed_i2c_get_bus(&soc->i2c, 8),
+                                        "pca9548", 0x70);
+    i2c_slave_create_simple(pca954x_i2c_get_bus(therm_mux, 0), TYPE_LM75, 
0x4C);
+    i2c_slave_create_simple(pca954x_i2c_get_bus(therm_mux, 1), TYPE_LM75, 
0x4C);
+    i2c_slave_create_simple(pca954x_i2c_get_bus(therm_mux, 2), TYPE_LM75, 
0x48);
+    i2c_slave_create_simple(pca954x_i2c_get_bus(therm_mux, 3), TYPE_LM75, 
0x48);
+    i2c_slave_create_simple(pca954x_i2c_get_bus(therm_mux, 4), TYPE_LM75, 
0x48);
+
      /* I2C9 Fan Controller (MAX31785) */
      i2c_slave_create_simple(aspeed_i2c_get_bus(&soc->i2c, 9), "max31785", 
0x52);
      i2c_slave_create_simple(aspeed_i2c_get_bus(&soc->i2c, 9), "max31785", 
0x54);