On Thu, Jun 23, 2022 at 10:47 PM Eric Blake <ebl...@redhat.com> wrote: > I did not get through all of the callers (you are right, there ARE a > lot), but the ones I checked, particularly in block/qcow2-*.c, appear > to handle -EIO just fine. > > I did notice, however, that qcow2-bitmap.c:free_bitmap_clusters() > returns an int failure, but none of its three callers > (qcow2_co_remove_persistent_dirty_bitmap, and twice in > qcow2_store_persistent_dirty_bitmaps) care about the return value. > That may be worth a separate cleanup patch.
Thanks, Eric. I decided to add a check for this kind of thing to the static analyzer I've been working on, which I sent as an RFC [1]. Alberto [1] https://lore.kernel.org/qemu-devel/20220702113331.2003820-1-afa...@redhat.com/
