Re: [PATCH 5/5] target/loongarch/op_helper: Fix coverity cond_at_most error

[Richard Henderson]

On 7/12/22 13:31, Xiaojuan Yang wrote:

The boundary size of cpucfg array should be 0 to 20. So,
using index bigger than 20 to access cpucfg[] must be forbidden.

Fix coverity CID: 1489760

Signed-off-by: Xiaojuan Yang <yangxiaoj...@loongson.cn>
---
  target/loongarch/op_helper.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/target/loongarch/op_helper.c b/target/loongarch/op_helper.c
index 4b429b6699..b05a0b7648 100644
--- a/target/loongarch/op_helper.c
+++ b/target/loongarch/op_helper.c
@@ -81,7 +81,7 @@ target_ulong helper_crc32c(target_ulong val, target_ulong m, 
uint64_t sz)

target_ulong helper_cpucfg(CPULoongArchState *env, target_ulong rj)

  {
-    return rj > 21 ? 0 : env->cpucfg[rj];
+    return rj > 20 ? 0 : env->cpucfg[rj];

Better using ARRAY_SIZE(env->cpucfg).


r~