On Thu, Jul 21, 2022 at 04:02:49PM +0000, Zhao, Zhou wrote: > Hi dainel: > Cause our code depend on intel intrinsics lib implement. And > this lib depend on macro like " AVX512BW ". This macro need > compile time check to enable some machine options . if you only > use that utility to do runtime check ,you will met compile issue. > And also if we want to save cpu time , we'd better check it in > compile time.
Can you give more info about this library ? The patch isn't linking to any new library so it was not immediately obvious that this patch even introduced a dependancy on an external library. Preferrably the library would be using 'pkg-config' so we can check for it in a single line of meson.build code instead of writing 100's of lines of configure compile tests. Generally if the library is available in Linux dijstros, then we'll want the CI to test that too, which will mean updating the dockerfiles. With regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
