Re: [PATCH for-7.2 02/10] hw/ppc/pegasos2.c: set machine->fdt in machine_reset()

[BALATON Zoltan]

On Fri, 22 Jul 2022, Daniel Henrique Barboza wrote:
We'll introduce HMP commands that requires machine->fdt to be set
properly.
Cc: BALATON Zoltan <bala...@eik.bme.hu>
Cc: qemu-...@nongnu.org
Signed-off-by: Daniel Henrique Barboza <danielhb...@gmail.com>
---
hw/ppc/pegasos2.c | 3 +++
1 file changed, 3 insertions(+)

diff --git a/hw/ppc/pegasos2.c b/hw/ppc/pegasos2.c
index 61f4263953..9827c3b4c2 100644
--- a/hw/ppc/pegasos2.c
+++ b/hw/ppc/pegasos2.c
@@ -329,6 +329,9 @@ static void pegasos2_machine_reset(MachineState *machine)
    g_free(pm->fdt_blob);
    pm->fdt_blob = fdt;

+    /* Set common MachineState->fdt */
+    machine->fdt = fdt;
+

Again, comment just states what the next line does but does not explain 
why. Either add a comment that explains why it's set or drop the trivial 
comment. Otherwise,

Acked-by: BALATON Zoltan <bala...@eik.bme.hu>

    vof_build_dt(fdt, pm->vof);
    vof_client_open_store(fdt, pm->vof, "/chosen", "stdout", "/failsafe");
    pm->cpu->vhyp = PPC_VIRTUAL_HYPERVISOR(machine);