On Sat, 23 Jul 2022 at 12:15, alanjian85 <alanjia...@gmail.com> wrote: > > This patch fixes the dedicated framebuffer mailbox interface(marked as > deprecated in official docs, but can still be fixed for emulation purposes) > by removing unneeded offset to make it works like buffer allocate tag in > bcm2835_property interface[1], some baremetal applications like the > Screen01/Screen02 examples from Baking Pi tutorial[2] didn't work > before this patch. > > [1] https://github.com/qemu/qemu/blob/master/hw/misc/bcm2835_property.c#L158 > [2] https://www.cl.cam.ac.uk/projects/raspberrypi/tutorials/os/screen01.html > > Signed-off-by: alanjian85 <alanjia...@outlook.com>
Thanks for this patch. Our submission rules require a full personal name in the Signed-off-by line, not just a username. We can't take the patch without this, I'm afraid. > --- > hw/display/bcm2835_fb.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) Is there any difference between this patch and the one you sent a few days previously? https://patchew.org/QEMU/20220721081544.38228-1-alanjia...@outlook.com/ Generally if you're sending an updated version of patch it's helpful to mark it as "[PATCH v2]" or whatever, and to include a note below the '---' line that says what the changes are. thanks -- PMM