On 27/07/2022 14:09, Daniel P. Berrangé wrote:
On Wed, Jul 27, 2022 at 01:36:25PM -0300, Lucas Mateus Castro(alqotel) wrote:
Currently the run script uses 'readlink -e' but the image only has the
busybox readlink, this commit add the coreutils package which
contains the readlink with the '-e' option.
Use of 'readlink' is discouraged in favour of 'realpath'. AFAICT, we
can just do that change and not need the '-e' flag anyway.
So a patch just changing
-BASE="$(dirname $(readlink -e $0))"
+BASE="$(dirname $(realpath $0))"
Ok, I'll send it with v2.
Signed-off-by: Lucas Mateus Castro(alqotel)<lucas.ara...@eldorado.org.br>
---
tests/docker/dockerfiles/alpine.docker | 1 +
1 file changed, 1 insertion(+)
diff --git a/tests/docker/dockerfiles/alpine.docker
b/tests/docker/dockerfiles/alpine.docker
index 3f4c0f95cb..2943a99730 100644
--- a/tests/docker/dockerfiles/alpine.docker
+++ b/tests/docker/dockerfiles/alpine.docker
@@ -21,6 +21,7 @@ RUN apk update && \
cdrkit \
ceph-dev \
clang \
+ coreutils \
ctags \
curl-dev \
cyrus-sasl-dev \
This file contents is autogenerated, so editting it manually is
wrong and changes will be lost.
True, that was one of the reasons I had problems with patch 8 (it
changes the dockerfiles directly) but forgot that it'd apply here as well.
Thanks,
--
Lucas Mateus M. Araujo e Castro
Instituto de Pesquisas ELDORADO
<https://www.eldorado.org.br/?utm_campaign=assinatura_de_e-mail&utm_medium=email&utm_source=RD+Station>
Departamento Computação Embarcada
Analista de Software Trainee
Aviso Legal - Disclaimer <https://www.eldorado.org.br/disclaimer.html>
