On 12/16/2011 11:00 AM, Paolo Bonzini wrote:
On 12/16/2011 03:01 PM, Paolo Bonzini wrote:
I'd rather use generic errors when possible. How about
VALUE_OUT_OF_RANGE and we can make the message "'%(item)' doesn't take
value..." and pass "%s.%s" % (device, property) for item.
Ok.
I didn't do this in the end for two reasons.
First, that it is inconsistent with other errors from qdev properties. Current
master does not raise them when properties are accessed via QOM, but my revised
series does.
Second, that it is actually provides less structured information. There's no
reason why a client should be expected to "know" that %(item) is in that form.
Ok, then Reviewed-by: Anthony Liguori <aligu...@us.ibm.com>
Regards,
Anthony Liguori
Paolo
