On Tue, 9 Aug 2022 at 19:48, Ben Dooks <b...@fluff.org> wrote: > > On Mon, Aug 01, 2022 at 12:37:33PM +0100, Peter Maydell wrote: > > On Wed, 27 Jul 2022 at 23:44, Ben Dooks <q...@ben.fluff.org> wrote: > > > @@ -285,8 +280,6 @@ static void fdt_add_gem_nodes(VersalVirt *s) > > > > > > static void fdt_add_zdma_nodes(VersalVirt *s) > > > { > > > - const char clocknames[] = "clk_main\0clk_apb"; > > > - const char compat[] = "xlnx,zynqmp-dma-1.0"; > > > > This looks suspiciously like a pre-existing bug to me. > > Alaistair, Edgar -- shouldn't this be a NUL-separated > > 'compatible' string, rather than a comma-separated one? > > I think the compat[] is fine, I should have probably added I also fixed > up to just call qemu_fdt_setprop_string()
I guess if it's definitely supposed to be one string instead of two that's OK. -- PMM