On Thu, Aug 18, 2022 at 11:58 PM Peter Maydell <peter.mayd...@linaro.org> wrote: > > On Thu, 18 Aug 2022 at 05:20, Alistair Francis <alistai...@gmail.com> wrote: > > > > On Tue, Aug 16, 2022 at 5:11 AM Peter Maydell <peter.mayd...@linaro.org> > > wrote: > > > > > > The riscv target incorrectly enabled semihosting always, whether the > > > user asked for it or not. Call semihosting_enabled() passing the > > > correct value to the is_userspace argument, which fixes this and also > > > handles the userspace=on argument. > > > > > > Note that this is a behaviour change: we used to default to > > > semihosting being enabled, and now the user must pass > > > "-semihosting-config enable=on" if they want it. > > > > > > Signed-off-by: Peter Maydell <peter.mayd...@linaro.org> > > > > I agree with Richard that a check in translate would be better, but > > this is also an improvement on the broken implementation we have now > > Do you have an opinion on whether there are likely to be many > users who are using riscv semihosting without explicitly enabling it > on the command line ?
I don't think there are many users. We have always stated that semihosting had to be enabled via the command line Alistair > > -- PMM