On 20 December 2011 11:00, Avi Kivity <a...@redhat.com> wrote: > On 12/19/2011 06:45 PM, Peter Maydell wrote: >> Use the new memory mutator API to simplify the flash remap code; >> this allows us to drop the flash_mapped flag. >> >> This patch also fixes the sense of the REMAP bit, which was >> reversed. >> > > I'm surprised the word "also" doesn't cause the maintainers' scripts to > auto-reject the patch. It makes the patch hard to review, and also > makes cherry picking for updating stable releases harder.
Well, if you like I could split it into one patch which just changes the "if (flash) {" in integratorcm_do_remap() to "if (!flash) {", and then another patch which was exactly this one, but I don't think that makes this patch easier to review, because it's exactly the same size. I do kinda agree that it was a bit borderline putting both things into one patch, though. -- PMM