On Sun, 28 Aug 2022, Richard Henderson wrote:
The value previously chosen overlaps GUSA_MASK.Cc: qemu-sta...@nongnu.org Fixes: 4da06fb3062 ("target/sh4: Implement prctl_unalign_sigbus") Resolves: https://gitlab.com/qemu-project/qemu/-/issues/856 Signed-off-by: Richard Henderson <richard.hender...@linaro.org> --- target/sh4/cpu.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/target/sh4/cpu.h b/target/sh4/cpu.h index 9f15ef913c..e79cbc59e2 100644 --- a/target/sh4/cpu.h +++ b/target/sh4/cpu.h @@ -84,7 +84,7 @@ #define DELAY_SLOT_RTE (1 << 2) #define TB_FLAG_PENDING_MOVCA (1 << 3) -#define TB_FLAG_UNALIGN (1 << 4) +#define TB_FLAG_UNALIGN (1 << 13)
Is it worth a comment to note why that value to avoid the same problem if another flag is added in the future?
Regards, BALATON Zoltan
#define GUSA_SHIFT 4 #ifdef CONFIG_USER_ONLY
