Hi
On Wed, Aug 24, 2022 at 2:20 PM Bin Meng <bmeng...@gmail.com> wrote:
> From: Bin Meng <bin.m...@windriver.com>
>
> There is a difference in the mkdir() call for win32 and non-win32
> platforms, and currently is handled in the codes with #ifdefs.
>
> glib provides a portable g_mkdir_with_parents() API and we can use
> it to unify the codes without #ifdefs.
>
Why use the _with_parents() version?
You should replace with g_mkdir(), or explain the reasons.
thanks
>
> Signed-off-by: Bin Meng <bin.m...@windriver.com>
> ---
>
> block/vvfat.c | 8 ++------
> 1 file changed, 2 insertions(+), 6 deletions(-)
>
> diff --git a/block/vvfat.c b/block/vvfat.c
> index d6dd919683..9c389ce5ea 100644
> --- a/block/vvfat.c
> +++ b/block/vvfat.c
> @@ -2726,13 +2726,9 @@ static int
> handle_renames_and_mkdirs(BDRVVVFATState* s)
> mapping_t* mapping;
> int j, parent_path_len;
>
> -#ifdef __MINGW32__
> - if (mkdir(commit->path))
> + if (g_mkdir_with_parents(commit->path, 0755)) {
> return -5;
> -#else
> - if (mkdir(commit->path, 0755))
> - return -5;
> -#endif
> + }
>
> mapping = insert_mapping(s, commit->param.mkdir.cluster,
> commit->param.mkdir.cluster + 1);
> --
> 2.34.1
>
>
>
--
Marc-André Lureau
