On Wed, Aug 31, 2022 at 9:50 PM Marc-André Lureau <marcandre.lur...@gmail.com> wrote: > > Hi > > On Wed, Aug 24, 2022 at 2:31 PM Bin Meng <bmeng...@gmail.com> wrote: >> >> From: Xuzhou Cheng <xuzhou.ch...@windriver.com> >> >> Currently signal SIGIPI [=SIGUSR1] is used to kick the dummy CPU >> when qtest accelerator is used. However SIGUSR1 is unsupported on >> Windows. To support Windows, we add a QemuSemaphore CPUState::sem >> to kick the dummy CPU instead for Windows. >> >> Signed-off-by: Xuzhou Cheng <xuzhou.ch...@windriver.com> >> Signed-off-by: Bin Meng <bin.m...@windriver.com> > > > What if we replace signals by the semaphore on posix as well?
Yeah, with that we can make this a complete portable implementation. Will do in v2. > > but lgtm, > Reviewed-by: Marc-André Lureau <marcandre.lur...@redhat.com> > >> >> --- >> >> include/hw/core/cpu.h | 1 + >> accel/dummy-cpus.c | 14 ++++++++++++-- >> softmmu/cpus.c | 9 +++++---- >> accel/meson.build | 1 + >> accel/qtest/meson.build | 1 + >> 5 files changed, 20 insertions(+), 6 deletions(-) >> Regards, Bin
