On Tue, Sep 13, 2022 at 08:39:52AM +0200, Laurent Vivier wrote: > From: Stefano Brivio <sbri...@redhat.com> > > Other errors are treated as failure by net_stream_client_init(), > but if connect() returns EINVAL, we'll fail silently. Remove the > related exception.
Is this also a bug in net_socket_connect_init()? Is there an equivalent bug in dgram.c? > Signed-off-by: Stefano Brivio <sbri...@redhat.com> > [lvivier: applied to net/stream.c] > Signed-off-by: Laurent Vivier <lviv...@redhat.com> > Reviewed-by: Daniel P. Berrangé <berra...@redhat.com> > --- > net/stream.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/net/stream.c b/net/stream.c > index 0851e90becca..e8afbaca50b6 100644 > --- a/net/stream.c > +++ b/net/stream.c > @@ -363,8 +363,7 @@ static int net_stream_client_init(NetClientState *peer, > if (errno == EINTR || errno == EWOULDBLOCK) { > /* continue */ > } else if (errno == EINPROGRESS || > - errno == EALREADY || > - errno == EINVAL) { > + errno == EALREADY) { > break; > } else { > error_setg_errno(errp, errno, "can't connect socket"); -- David Gibson | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ | _way_ _around_! http://www.ozlabs.org/~dgibson
signature.asc
Description: PGP signature