On Thu, Sep 15, 2022 at 10:42:57PM +0200, Markus Armbruster wrote: > The has_FOO for pointer-valued FOO are redundant, except for arrays. > They are also a nuisance to work with. Recent commit "qapi: Start to > elide redundant has_FOO in generated C" provided the means to elide > them step by step. This is the step for qapi/audio.json. > > Said commit explains the transformation in more detail. The invariant > violations mentioned there do not occur here. > > Additionally, helper get_str() loses its @has_dst parameter. > > Cc: Gerd Hoffmann <kra...@redhat.com> > Signed-off-by: Markus Armbruster <arm...@redhat.com> > --- > audio/alsaaudio.c | 2 +- > audio/audio.c | 6 ++---- > audio/audio_legacy.c | 17 +++++++---------- > audio/ossaudio.c | 8 +++----- > audio/paaudio.c | 12 ++++++------ > audio/wavaudio.c | 2 +- > scripts/qapi/schema.py | 1 - > 7 files changed, 20 insertions(+), 28 deletions(-)
Reviewed-by: Daniel P. Berrangé <berra...@redhat.com> With regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
