Hi Markus,
On 2/9/22 14:24, Markus Armbruster wrote:
Dongli Zhang <dongli.zh...@oracle.com> writes:
The below is printed when printing help information in qemu-system-x86_64
command line, and when CONFIG_TRACE_LOG is enabled:
----------------------------
$ qemu-system-x86_64 -d help
... ...
trace:PATTERN enable trace events
Use "-d trace:help" to get a list of trace events.
----------------------------
However, the options of "trace:PATTERN" are only printed by
"qemu-system-x86_64 -d help", but missing in hmp "help log" command.
Fixes: c84ea00dc2 ("log: add "-d trace:PATTERN"")
Cc: Joe Jin <joe....@oracle.com>
Signed-off-by: Dongli Zhang <dongli.zh...@oracle.com>
---
Changed since v1:
- change format for "none" as well.
Changed since v2:
- use "log trace:help" in help message.
- add more clarification in commit message.
- add 'Fixes' tag.
---
monitor/hmp.c | 9 +++++++--
1 file changed, 7 insertions(+), 2 deletions(-)
Not this patch's fault:
1. "-d help" terminates with exit status 1, "-d trace:help" with 0. The
former is wrong.
2. HMP "log trace:help" prints to stdout instead of the current monitor.
3. Output of HMP "log trace:help" sometimes is truncated for me.
4. Output of "log trace:help" and "info trace-events" is unwieldy.
Sorted output could be a bit less unwieldy.
5. Could "log trace:help" and "info trace-events" share code?
Do you mind opening issue(s) on our GitLab so we don't loose your
analysis buried within the infinite mailing list?