"Michael S. Tsirkin" <m...@redhat.com> writes:
> On Tue, Sep 20, 2022 at 02:25:48PM -0400, Stefan Hajnoczi wrote: >> On Tue, 20 Sept 2022 at 10:18, Alex Bennée <alex.ben...@linaro.org> wrote: >> > >> > >> > Stefan Hajnoczi <stefa...@redhat.com> writes: >> > >> > > [[PGP Signed Part:Undecided]] >> > > On Fri, Sep 16, 2022 at 07:51:40AM +0100, Alex Bennée wrote: >> > >> >> > >> Alex Bennée <alex.ben...@linaro.org> writes: >> > >> >> > >> > Hi, >> > >> > >> > >> > This is an update to the previous series which fixes the last few >> > >> > niggling CI failures I was seeing. >> > >> > >> > >> > Subject: [PATCH v3 for 7.2 00/21] virtio-gpio and various virtio >> > >> > cleanups >> > >> > Date: Tue, 26 Jul 2022 20:21:29 +0100 >> > >> > Message-Id: <20220726192150.2435175-1-alex.ben...@linaro.org> >> > >> > >> > >> > The CI failures were tricky to track down because they didn't occur >> > >> > locally but after patching to dump backtraces they all seem to involve >> > >> > updates to virtio_set_status() as the machine was torn down. I think >> > >> > patch that switches all users to use virtio_device_started() along >> > >> > with consistent checking of vhost_dev->started stops this from >> > >> > happening. The clean-up seems worthwhile in reducing boilerplate >> > >> > anyway. >> > >> > >> > >> > The following patches still need review: >> > >> > >> > >> > - tests/qtest: enable tests for virtio-gpio >> > >> > - tests/qtest: add a get_features op to vhost-user-test >> > >> > - tests/qtest: implement stub for VHOST_USER_GET_CONFIG >> > >> > - tests/qtest: add assert to catch bad features >> > >> > - tests/qtest: plain g_assert for VHOST_USER_F_PROTOCOL_FEATURES >> > >> > - tests/qtest: catch unhandled vhost-user messages >> > >> > - tests/qtest: use qos_printf instead of g_test_message >> > >> > - tests/qtest: pass stdout/stderr down to subtests >> > >> > - hw/virtio: move vhd->started check into helper and add FIXME >> > >> > - hw/virtio: move vm_running check to virtio_device_started >> > >> > - hw/virtio: add some vhost-user trace events >> > >> > - hw/virtio: log potentially buggy guest drivers >> > >> > - hw/virtio: fix some coding style issues >> > >> > - include/hw: document vhost_dev feature life-cycle >> > >> > - include/hw/virtio: more comment for VIRTIO_F_BAD_FEATURE >> > >> > - hw/virtio: fix vhost_user_read tracepoint >> > >> > - hw/virtio: handle un-configured shutdown in virtio-pci >> > >> > - hw/virtio: gracefully handle unset vhost_dev vdev >> > >> > - hw/virtio: incorporate backend features in features >> > >> <snip> >> > >> >> > >> Ping? >> > > >> > > Who are you pinging? >> > > >> > > Only qemu-devel is on To and there are a bunch of people on Cc. >> > >> > Well I guess MST is the maintainer for the sub-system but I was hoping >> > other virtio contributors had some sort of view. The process of >> > up-streaming a simple vhost-user stub has flushed out all sorts of >> > stuff. >> >> Okay, moving MST to To in case it helps get his attention. >> >> Thanks, >> Stefan > > thanks, it's in my queue, just pulling in backlog that built up > during the forum. Thanks, doing the same myself ;-) -- Alex Bennée
