On Tue, 6 Sept 2022 at 11:12, Richard Henderson <richard.hender...@linaro.org> wrote: > > In preparation for TARGET_TB_PCREL, reduce reliance on absolute values. > > Signed-off-by: Richard Henderson <richard.hender...@linaro.org> > --- > target/arm/translate-a64.c | 40 ++++++++++++++++++++------------------ > target/arm/translate.c | 10 ++++++---- > 2 files changed, 27 insertions(+), 23 deletions(-) >
> @@ -14965,7 +14967,7 @@ static void aarch64_tr_tb_stop(DisasContextBase > *dcbase, CPUState *cpu) > switch (dc->base.is_jmp) { > case DISAS_NEXT: > case DISAS_TOO_MANY: > - gen_goto_tb(dc, 1, dc->base.pc_next); > + gen_goto_tb(dc, 1, curr_insn_len(dc)); Why does this one need to be curr_insn_len() when all the others in translate-a64.c used a hardcoded 4 ? Otherwise Reviewed-by: Peter Maydell <peter.mayd...@linaro.org> thanks -- PMM