On Tue, Sep 20, 2022 at 2:56 PM Bin Meng <bmeng...@gmail.com> wrote:
> From: Bin Meng <bin.m...@windriver.com>
>
> There is no need to do a type cast on ssource->socket as it is
> already declared as a SOCKET.
>
> Suggested-by: Marc-André Lureau <marcandre.lur...@redhat.com>
> Signed-off-by: Bin Meng <bin.m...@windriver.com>
>
Reviewed-by: Marc-André Lureau <marcandre.lur...@redhat.com>
---
>
> Changes in v2:
> - new patch: "io/channel-watch: Drop the unnecessary cast"
>
> io/channel-watch.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/io/channel-watch.c b/io/channel-watch.c
> index 89f3c8a88a..43d38494f7 100644
> --- a/io/channel-watch.c
> +++ b/io/channel-watch.c
> @@ -130,13 +130,13 @@ qio_channel_socket_source_check(GSource *source)
> FD_ZERO(&wfds);
> FD_ZERO(&xfds);
> if (ssource->condition & G_IO_IN) {
> - FD_SET((SOCKET)ssource->socket, &rfds);
> + FD_SET(ssource->socket, &rfds);
> }
> if (ssource->condition & G_IO_OUT) {
> - FD_SET((SOCKET)ssource->socket, &wfds);
> + FD_SET(ssource->socket, &wfds);
> }
> if (ssource->condition & G_IO_PRI) {
> - FD_SET((SOCKET)ssource->socket, &xfds);
> + FD_SET(ssource->socket, &xfds);
> }
> ssource->revents = 0;
> if (select(0, &rfds, &wfds, &xfds, &tv0) == 0) {
> --
> 2.34.1
>
>
>
--
Marc-André Lureau
