On 27 December 2011 20:13, Mark Langsdorf <mark.langsd...@calxeda.com> wrote:
> This adds very basic support for XG-mac ethernet core from Synopsis and
> others. Missing things include:
> + if ((bd.buffer1_size & 0xfff) > 2048) {
> + fprintf(stdout, "qemu:%s:ERROR...ERROR...ERROR... -- "
> + "xgmac buffer 1 len on send > 2048 (0x%x)\n",
> + __func__, bd.buffer1_size & 0xfff);
> + fflush(stdout);
> + }
This kind of chattiness (a) usually goes on stderr
(which would let you drop that fflush) (b)
is usually a macro so you can enable/disable it.
Otherwise looks OK I think (that's more of a "will-let-pass"
than a confident "reviewed" :-)).
-- PMM
