On Fri, Sep 23, 2022 at 4:18 AM Marc-André Lureau <marcandre.lur...@gmail.com> wrote: > > Hi > > On Tue, Sep 20, 2022 at 3:37 PM Bin Meng <bmeng...@gmail.com> wrote: >> >> From: Bin Meng <bin.m...@windriver.com> >> >> Now that we have fixed various test case issues as seen when running >> on Windows, let's enable the qtest build on Windows. >> >> Signed-off-by: Bin Meng <bin.m...@windriver.com> >> --- >> >> Changes in v2: >> - new patch: "tests/qtest: Enable qtest build on Windows" >> >> tests/qtest/meson.build | 5 ++--- >> 1 file changed, 2 insertions(+), 3 deletions(-) >> >> diff --git a/tests/qtest/meson.build b/tests/qtest/meson.build >> index 455f1bbb7e..ceab141824 100644 >> --- a/tests/qtest/meson.build >> +++ b/tests/qtest/meson.build >> @@ -1,6 +1,5 @@ >> -# All QTests for now are POSIX-only, but the dependencies are >> -# really in libqtest, not in the testcases themselves. >> -if not config_host.has_key('CONFIG_POSIX') >> +# Build all QTests for POSIX and Windows >> +if not config_host.has_key('CONFIG_POSIX') and not >> config_host.has_key('CONFIG_WIN32') >> subdir_done() >> endif > > > I wonder, but I suppose we can just remove the conditions. No?
Yes, I think so. Regards, Bin