Am 31.12.2011 05:54, schrieb Richard Henderson: > The macro uses the DisasContext. Pass it around as needed.
This fixes a build failure, right? Order it first then? Since there's no cover letter, series looks mostly good. Some minor comments. > > Signed-off-by: Richard Henderson <r...@twiddle.net> > --- > target-mips/translate.c | 80 > ++++++++++++++++++++++++++--------------------- > 1 files changed, 44 insertions(+), 36 deletions(-) > > diff --git a/target-mips/translate.c b/target-mips/translate.c > index 8908c8c..11272b6 100644 > --- a/target-mips/translate.c > +++ b/target-mips/translate.c > @@ -1489,7 +1489,8 @@ static void gen_arith_imm (CPUState *env, DisasContext > *ctx, uint32_t opc, > } > > /* Logic with immediate operand */ > -static void gen_logic_imm (CPUState *env, uint32_t opc, int rt, int rs, > int16_t imm) > +static void gen_logic_imm (CPUState *env, DisasContext *ctx, uint32_t opc, > + int rt, int rs, int16_t imm) When you touch the declaration, please fix Coding Style by removing the extra space before the bracket. Applies to 1-4. Andreas -- SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg
