On 10/7/2022 4:33 PM, Warner Losh wrote:


On Fri, Oct 7, 2022 at 1:21 AM Brad Smith <b...@comstyle.com> wrote:

    tests: Add sndio to the FreeBSD CI containers / VM

    ---
     .gitlab-ci.d/cirrus/freebsd-12.vars           |   2 +-
     .gitlab-ci.d/cirrus/freebsd-13.vars           |   2 +-
     tests/docker/dockerfiles/alpine.docker        |   3 +-
     tests/docker/dockerfiles/centos8.docker       |   2 +-
     .../dockerfiles/debian-amd64-cross.docker     | 235 ++++++++---------
     tests/docker/dockerfiles/debian-amd64.docker  | 237
    +++++++++---------
     .../dockerfiles/debian-arm64-cross.docker     | 233 ++++++++---------
     .../dockerfiles/debian-armel-cross.docker     | 231 ++++++++---------
     .../dockerfiles/debian-armhf-cross.docker     | 233 ++++++++---------
     .../dockerfiles/debian-mips64el-cross.docker  | 227 ++++++++---------
     .../dockerfiles/debian-mipsel-cross.docker    | 227 ++++++++---------
     .../dockerfiles/debian-ppc64el-cross.docker   | 231 ++++++++---------
     .../dockerfiles/debian-s390x-cross.docker     | 229 ++++++++---------
     tests/docker/dockerfiles/fedora.docker        | 230 ++++++++---------
     tests/docker/dockerfiles/opensuse-leap.docker |   3 +-
     tests/docker/dockerfiles/ubuntu2004.docker    | 235 ++++++++---------
     tests/lcitool/libvirt-ci                      |   2 +-
     tests/lcitool/projects/qemu.yml               |   1 +
     tests/vm/freebsd                              |   3 +
     19 files changed, 1291 insertions(+), 1275 deletions(-)


This looks good to me. Why did the Linux containers need updating for the FreeBSD update?

Otherwise, the changes look good to my eye

Reviewed-by:  Warner Losh <i...@bsdimp.com>


Because the CI configs are auto-generated. When refreshing them it generates them all. The intent was to update the FreeBSD configs, but when adding the dependency to tests/lcitool/projects/qemu.yml the FreeBSD configs are updated as well as the rest. Whatever OS's have a corresponding mapping
in libvirt-ci are updated.

Reply via email to