On Tue, Oct 11, 2022 at 8:32 PM Thomas Huth <th...@redhat.com> wrote:
>
> On 06/10/2022 17.19, Bin Meng wrote:
> > From: Xuzhou Cheng <xuzhou.ch...@windriver.com>
> >
> > Currently signal SIGIPI [=SIGUSR1] is used to kick the dummy CPU
> > when qtest accelerator is used. However SIGUSR1 is unsupported on
> > Windows. To support Windows, we add a QemuSemaphore CPUState::sem
> > to kick the dummy CPU instead for Windows.
> >
> > Signed-off-by: Xuzhou Cheng <xuzhou.ch...@windriver.com>
> > Signed-off-by: Bin Meng <bin.m...@windriver.com>
> > Reviewed-by: Marc-André Lureau <marcandre.lur...@redhat.com>
> > ---
> >
> > Changes in v5:
> > - restore to v1 version which does not touch the posix implementation
> >
> > include/hw/core/cpu.h | 1 +
> > accel/dummy-cpus.c | 14 ++++++++++++--
> > softmmu/cpus.c | 9 +++++----
> > accel/meson.build | 1 +
> > accel/qtest/meson.build | 1 +
> > 5 files changed, 20 insertions(+), 6 deletions(-)
> ...
> > diff --git a/accel/meson.build b/accel/meson.build
> > index b9a963cf80..b21c85dc0a 100644
> > --- a/accel/meson.build
> > +++ b/accel/meson.build
> > @@ -17,4 +17,5 @@ dummy_ss.add(files(
> > ))
> >
> > specific_ss.add_all(when: ['CONFIG_SOFTMMU', 'CONFIG_POSIX'], if_true:
> > dummy_ss)
> > +specific_ss.add_all(when: ['CONFIG_WIN32'], if_true: dummy_ss)
>
> Sorry for not noticing it earlier, but I just noticed that this likely
> should also only be added for softmmu builds on Windows?
>
> So instead of adding a new line, I'd rather simply remove the CONFIG_POSIX
> from the previous line?
Yes, I think that should work.
>
> > specific_ss.add_all(when: ['CONFIG_XEN'], if_true: dummy_ss)
> > diff --git a/accel/qtest/meson.build b/accel/qtest/meson.build
> > index 4c65600293..a4876fc0f2 100644
> > --- a/accel/qtest/meson.build
> > +++ b/accel/qtest/meson.build
> > @@ -1,2 +1,3 @@
> > qtest_module_ss.add(when: ['CONFIG_SOFTMMU', 'CONFIG_POSIX'],
> > if_true: files('qtest.c'))
> > +qtest_module_ss.add(when: ['CONFIG_WIN32'], if_true: files('qtest.c'))
>
> Dito, rather remove the CONFIG_POSIX in the previous line?
>
Regards,
Bin
